From f27783967914b68dc83d0048a45e26db2b47e511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=B2=E8=8F=AF?= <42814579+yunwah@users.noreply.github.com> Date: Tue, 17 Aug 2021 20:24:53 -0400 Subject: [PATCH] fixed returning none as a result returning reverse function Reverse does everything inplace and does not return a reversed list hence resulting in a broken script. --- Dockerfile | 1 + news.py | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 17a42a9..141929d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -10,4 +10,5 @@ RUN python3 -m venv venv && \ RUN mkdir database && \ touch database/news.db + CMD ["venv/bin/python", "main.py"] \ No newline at end of file diff --git a/news.py b/news.py index 09eee0b..8728509 100644 --- a/news.py +++ b/news.py @@ -72,12 +72,14 @@ class NewsScraper: _hash = hashlib.md5(article_meta.__str__().encode('UTF-8'), usedforsecurity=False).hexdigest() if self._check_hash(_hash, 'news_hashes'): - return + articles.reverse() + return articles else: self._store_hash(_hash, 'news_hashes') articles.append(article_meta) - return articles.reverse() + articles.reverse() + return articles async def close(self): await self.client.close()